fix govet issue and pin golangci-lint version for CI checks #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tariq Ibrahim <[email protected]>
klueska
approved these changes
Aug 20, 2024
|
@tariq1890 thanks for fixing this. I do see some benefits of using the latest version of golangci-lint in our CI -- 1) we do not need to maintain this version, and 2) we learn of new issues as golangci-lint is improved. |
|
I agree that unpinning the golangci-lint version helps us learn of new issues, however, I don't think it should cause CI failure. A CI failure should be a signal of a possibly bad change that is introduced through a changes directly introduced by the commit author. In this case, we are getting CI failures that don't pertain to any change introduced by a committer. I think we should use a tool like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a go vet lint issue which started to surface in the main branch on the latest golangci-lint version. Since we don't pin the version of golangci-lint in our GitHub action, there is no guarantee of CI check stability as the latest stable release of golangci-lint is always pulled at the time of running the CI. This PR solves this problem by pinning the version of golangc-lint so that the CI checks are stable and consistent