Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add H200 with PCI ID 0x233510DE #121

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

KeithMnemonic
Copy link
Contributor

This PR updates the config-default.yaml to include the GPU ID for the NVIDIA H200.
In addition, other changes were added to sync this file with the

assets/state-mig-manager/0400_configmap.yaml

in https://github.com/NVIDIA/gpu-operator/

These files should contain the same information but have drifted over time.

Fixes: #120

This PR updates the config-default.yaml to
include the GPU ID for the NVIDIA H200.  In
addition, other changes were added to sync
this file with the

assets/state-mig-manager/0400_configmap.yaml

in https://github.com/NVIDIA/gpu-operator/

These files should contain the same
information but have drifted over time.

Signed-off-by: KeithMnemonic <[email protected]>
@klueska
Copy link
Contributor

klueska commented Sep 4, 2024

It's hard to tell what is net-new vs. just refactoring / consolidating with the GPU operator. Can you separate this into two commits (one for consolidating with the GPU operator., and one for adding the new GPU)?

@KeithMnemonic
Copy link
Contributor Author

It's hard to tell what is net-new vs. just refactoring / consolidating with the GPU operator. Can you separate this into two commits (one for consolidating with the GPU operator., and one for adding the new GPU)?

If the contents of the file are meant to be identical other than a few lines at the top and the tabs, is a diff of the file from the GPU operator not sufficient? There were other missing things that were in the configmap that were not in the config-default as well that I added in. I can send you the configmap .yaml I used

@klueska
Copy link
Contributor

klueska commented Sep 4, 2024

If @cdesiniotis is confident that the diff is accurate and that we now have parity with the operator, then that is good enough for me. I'll let him do the final sign-off.

@cdesiniotis
Copy link
Contributor

I've downloaded the config file from this PR and the latest config file included in the gpu-operator repository and confirmed the content is the same.

@cdesiniotis cdesiniotis merged commit e906966 into NVIDIA:main Sep 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the NVIDIA H200 GPU
3 participants