Update nvidia-gpu-reset.target setup #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeithMnemonic
force-pushed
the
add_nvidia_gpu_reset_target_to_pkg_build_files
branch
from
5fece20
to
3374d2b
Compare
This PR fixes an incorrect entry in the nvidia-mig-manager.service. The "WantedBy" needs to point to multi-user.target otherwise unless something "Requires" or "Wants" nvidia-mig-manager it will not ever be started. Also the original patch that added the target did not update the debian Makefile and RPM spec file. This resulted in the target not being installed. Signed-off-by: KeithMnemonic <[email protected]>
KeithMnemonic
force-pushed
the
add_nvidia_gpu_reset_target_to_pkg_build_files
branch
from
3374d2b
to
c4615ad
Compare
cdesiniotis
requested review from
klueska,
elezar,
tariq1890 and
cdesiniotis
klueska
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an incorrect entry in the
nvidia-mig-manager.service. The "WantedBy" needs
to point to multi-user.target otherwise unless
something "Requires" or "Wants" nvidia-mig-manager it will not ever be started.
Also the original patch that added the target did not update the debian Makefile and RPM spec file. This resulted in the target not being installed.