Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github actions #32

Merged
merged 7 commits into from
Jan 28, 2024
Merged

Add github actions #32

merged 7 commits into from
Jan 28, 2024

Conversation

elezar
Copy link
Member

@elezar elezar commented Jan 28, 2024 •
edited
Loading

This PR does the following:

  • Update the golang version to v1.20.4 to allow for the use of the k8s-test-infra images
  • Use CUDA base images to minimize the risk of GLIBC version mismatches caused by Golang updates
  • Switch to using the k8s-test-infra images
  • Add GitHub CI actions

ArangoGutierrez
ArangoGutierrez requested changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Evan

.github/workflows/image.yaml Outdated Show resolved Hide resolved
.github/workflows/image.yaml Outdated Show resolved Hide resolved
@elezar elezar self-assigned this Jan 28, 2024
ArangoGutierrez
ArangoGutierrez requested changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove all Blossom related actions, there's no need for them

Run pre sanity / build (pull_request)

@elezar
Remove blossom-ci
cb0641f 
Signed-off-by: Evan Lezar <[email protected]>
@elezar elezar marked this pull request as ready for review January 28, 2024 12:50
ArangoGutierrez
ArangoGutierrez requested changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit

.github/workflows/golang.yaml Outdated Show resolved Hide resolved
@elezar elezar mentioned this pull request Jan 28, 2024
Merged
@elezar elezar mentioned this pull request Jan 28, 2024
Merged
ArangoGutierrez
ArangoGutierrez requested changes Jan 28, 2024
View reviewed changes
deployments/gpu-operator/Dockerfile.ubi8 Outdated Show resolved Hide resolved
deployments/gpu-operator/Dockerfile.ubuntu Outdated Show resolved Hide resolved
@elezar
Switch to CUDA base images
86bb919 
Signed-off-by: Evan Lezar <[email protected]>
@elezar
Use k8s-test-infra devel image
55c1881 
Signed-off-by: Evan Lezar <[email protected]>
@elezar
Fix Makefile path
3b3b7e7 
Signed-off-by: Evan Lezar <[email protected]>
@elezar
Skip golangci-lint
6f613fe 
Signed-off-by: Evan Lezar <[email protected]>
ArangoGutierrez
ArangoGutierrez approved these changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@elezar elezar merged commit cd4b684 into NVIDIA:main Jan 28, 2024
5 checks passed
@elezar elezar deleted the add-actions branch January 28, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

Assignees

@elezar elezar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elezar @ArangoGutierrez