Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang version in mig-manager dockerfiles #61

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

tariq1890
Copy link
Contributor

@tariq1890 tariq1890 commented Apr 19, 2024

Since we've marked the required go toolchain version as "1.22.2" in go.mod, I think it would be consistent to build the mig-parted binary with the same version

Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'm not opposed to that change, I just want to point out that this value is already overridden to 1.22.2 in our make process.

@tariq1890
Copy link
Contributor Author

@elezar Ack

@tariq1890 tariq1890 merged commit 10421cd into main Apr 19, 2024
9 checks passed
@tariq1890 tariq1890 deleted the bump-go-docker branch April 19, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants