Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump project version to v0.7.0 #62

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Bump project version to v0.7.0 #62

merged 2 commits into from
Apr 22, 2024

Conversation

cdesiniotis
Copy link
Contributor

No description provided.

Signed-off-by: Christopher Desiniotis <[email protected]>
Signed-off-by: Christopher Desiniotis <[email protected]>
@cdesiniotis
Copy link
Contributor Author

cdesiniotis commented Apr 19, 2024

Upon further thought, we could name this release v0.6.1 considering no new features were introduced. The release-0.6 branch has not diverted from main, so we could simply rebase release-0.6 and then create the v0.6.1 tag. Let me know if that is preferred and we can update this PR accordingly.

@@ -23,7 +23,7 @@ spec:
serviceAccountName: nvidia-mig-manager-service-account
containers:
- name: nvidia-mig-manager
image: nvcr.io/nvidia/cloud-native/k8s-mig-manager:v0.6.0-ubi8
image: nvcr.io/nvidia/cloud-native/k8s-mig-manager:v0.7.0-ubi8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocking comment. But we should consider publishing ubi9 images at some point

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that we need to replace the images?

Note that since we copy the mig-parted executable from the container to the host, we want to ensure that we're using as low a base version as possible to avoid issues with GLIBC dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant use ubi9 as the base image instead of ubi8

@cdesiniotis cdesiniotis changed the title Bump 0.7.0 Bump project version to v0.7.0 Apr 20, 2024
@cdesiniotis cdesiniotis merged commit 76371de into main Apr 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants