Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database #141

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ChrisJar
Copy link
Collaborator

@ChrisJar ChrisJar commented Oct 3, 2024

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

TODO:

  • Demonstrate add example vdbupload and store tasks (still working out how to hook this into llamaindex and langchain)
  • Demonstrate storing with minio and fetching and displaying some of the images

closes #122
closes #124

]
},
{
"cell_type": "markdown",
"id": "12d14f63-31b8-4d72-a029-a54328ff1c5b",
"metadata": {},
"source": [
"Then, we'll create a retriever from our vector score that will allow us to retrieve our documents by semantic similarity and an llm to synthesize the final answer from the retrieved documents"
"Then, we'll create a retriever from our vector score that will allow us to retrieve our documents by semantic similarity and we'll use an llm from NVIDIA's API catalog to generate the final answer from the retrieved documents"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Then, we'll create a retriever from our vector score that will allow us to retrieve our documents by semantic similarity and we'll use an llm from NVIDIA's API catalog to generate the final answer from the retrieved documents"
"Then, we'll create a retriever from our vector store that will allow us to retrieve our documents by semantic similarity and we'll use [llama-3.1-405b-instruct](https://build.nvidia.com/meta/llama-3_1-405b-instruct) to generate the final answer from the retrieved documents"

Copy link
Collaborator

@randerzander randerzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left several review comments to be addressed

@ChrisJar ChrisJar changed the title Use nvidia enpoints in example notebooks and demonstrate using milvus as a store" Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a store Oct 15, 2024
@ChrisJar ChrisJar changed the title Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a store Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database Oct 15, 2024
@ChrisJar ChrisJar changed the title Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database [Do Not Merge] Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database Oct 15, 2024
@ChrisJar ChrisJar changed the title [Do Not Merge] Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants