-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database #141
Open
ChrisJar
wants to merge
7
commits into
NVIDIA:main
Choose a base branch
from
ChrisJar:expand-examples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randerzander
reviewed
Oct 9, 2024
randerzander
reviewed
Oct 9, 2024
randerzander
reviewed
Oct 9, 2024
] | ||
}, | ||
{ | ||
"cell_type": "markdown", | ||
"id": "12d14f63-31b8-4d72-a029-a54328ff1c5b", | ||
"metadata": {}, | ||
"source": [ | ||
"Then, we'll create a retriever from our vector score that will allow us to retrieve our documents by semantic similarity and an llm to synthesize the final answer from the retrieved documents" | ||
"Then, we'll create a retriever from our vector score that will allow us to retrieve our documents by semantic similarity and we'll use an llm from NVIDIA's API catalog to generate the final answer from the retrieved documents" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"Then, we'll create a retriever from our vector score that will allow us to retrieve our documents by semantic similarity and we'll use an llm from NVIDIA's API catalog to generate the final answer from the retrieved documents" | |
"Then, we'll create a retriever from our vector store that will allow us to retrieve our documents by semantic similarity and we'll use [llama-3.1-405b-instruct](https://build.nvidia.com/meta/llama-3_1-405b-instruct) to generate the final answer from the retrieved documents" |
randerzander
reviewed
Oct 9, 2024
randerzander
reviewed
Oct 9, 2024
randerzander
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left several review comments to be addressed
ChrisJar
changed the title
Use nvidia enpoints in example notebooks and demonstrate using milvus as a store"
Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a store
Oct 15, 2024
ChrisJar
changed the title
Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a store
Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database
Oct 15, 2024
ChrisJar
changed the title
Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database
[Do Not Merge] Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database
Oct 15, 2024
ChrisJar
changed the title
[Do Not Merge] Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database
Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
TODO:
closes #122
closes #124