-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python tool picking up wrong JAR version in Fat wheel mode #1357
Conversation
Signed-off-by: Partho Sarthi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parthosa! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parthosa !
A couple of nits
Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTME!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parthosa!
Fixes #1355.
Currently, in fat wheel mode, the python tools uses a glob search to pick the the first JAR file that matches the pattern
rapids-4-spark-tools_*.jar
. This PR fixes this bug by selecting the exact JAR file that was packaged during the fat build.Changes
fatWheelModeJarFileName
Testing
24.08.2
and then for24.08.3-SNAPSHOT
24.08.3-SNAPSHOT
was picking up24.08.2
JAR.Before:
After:
Notes:
build.sh
to accept a custom JAR.