Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Exec Parsers - remove individual parser classes #1396

Merged
merged 6 commits into from
Nov 6, 2024

Commits on Oct 29, 2024

  1. Refactor Exec Parsers - unify the code calling similar methods

    This PR is to remove redundant code in many ExecParsers. We have
    several ExecParsers with the same functionality in parse code.
    In this PR, following changes are done:
    
    1. If the Execs don't have expressions, then execName is assigned and
    ExecInfo object is created from GenericExecParser.
    2. If the Execs have expressions then reflection is used to assign the
    appropriate parser to be used.
    3. If there is any additional calculation in the parse function, then
    only that part is overriden in the ExecParser and the rest of the
    function uses the GenereicExecParser base code
    4.Removed all the files which are not needed anymore
    
    Signed-off-by: Niranjan Artal <[email protected]>
    nartal1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    760f1d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Remove reflection instead use case classes to match and call respecti…

    …ve Parsers
    
    Signed-off-by: Niranjan Artal <[email protected]>
    nartal1 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    88e9c57 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. addressed few review comments

    1. default Exec name
    2. added argument to GenericParser constructor
    nartal1 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2dc2146 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. addressed review comments

    Signed-off-by: Niranjan Artal <[email protected]>
    nartal1 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    926d82a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    820d541 View commit details
    Browse the repository at this point in the history
  3. Update tests

    nartal1 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a1bdc3a View commit details
    Browse the repository at this point in the history