Add qualification support for Photon jobs in the Python Tool #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
parthosa
added
feature request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #251
This PR adds support for qualifying Photon jobs in the Python tool. We use a different strategy from Spark for qualifying Photon jobs.
Changes
Speed Up Strategy Builder
user_tools/src/spark_rapids_pytools/rapids/qualification.py:SpeedupStrategyBuilderand integrated it to dynamically build speedup strategies based on application type.user_tools/src/spark_rapids_tools/tools/speedup_category.py:SpeedupStrategyandSpeedupStrategyBuilderclasses to encapsulate speedup strategy logic.SpeedupCategoryto use these new classes. [1] [2] [3]New Configuration Options:
user_tools/src/spark_rapids_pytools/resources/qualification-conf.yaml:metricsSubFolderand new speedup strategy configurations for different application types. [1] [2] [3]user_tools/src/spark_rapids_pytools/rapids/tool_ctxt.py:get_metrics_output_foldermethod to retrieve the metrics output folder path.Minor Code Adjustments:
.pylintrc: Removed redundant pylint disable rules.