Skip to content

Commit

Permalink
Fix test case unix_timestamp(col, 'yyyyMMdd') failed for Africa/Casab…
Browse files Browse the repository at this point in the history
…lanca timezone and LEGACY mode

Signed-off-by: Chong Gao <[email protected]>
  • Loading branch information
Chong Gao committed Oct 8, 2024
1 parent 8207f7b commit 0218828
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion docs/compatibility.md
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ LEGACY timeParserPolicy support has the following limitations when running on th
- The proleptic Gregorian calendar is used instead of the hybrid Julian+Gregorian calendar
that Spark uses in legacy mode
- When format is `yyyyMMdd`, GPU only supports 8 digit strings. Spark supports like 7 digit
`2024101` string while GPU does not support.
`2024101` string while GPU does not support. Only tested `UTC` and `Asia/Shanghai` timezones.

## Formatting dates and timestamps as strings

Expand Down
1 change: 1 addition & 0 deletions integration_tests/src/main/python/date_time_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,7 @@ def test_to_timestamp(parser_policy):

@pytest.mark.skipif(not is_supported_time_zone(), reason="not all time zones are supported now, refer to https://github.com/NVIDIA/spark-rapids/issues/6839, please update after all time zones are supported")
# Test years after 1900, refer to issues: https://github.com/NVIDIA/spark-rapids/issues/11543, https://github.com/NVIDIA/spark-rapids/issues/11539
@pytest.mark.skipif(get_test_tz() != "Asia/Shanghai" or get_test_tz() != "UTC", reason="https://github.com/NVIDIA/spark-rapids/issues/11562")
def test_yyyyMMdd_format_for_legacy_mode():
gen = StringGen('(19[0-9]{2}|[2-9][0-9]{3})([0-9]{4})')
assert_gpu_and_cpu_are_equal_sql(
Expand Down

0 comments on commit 0218828

Please sign in to comment.