Update host memory allocation to use new Raw alloc APIs #10412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
previously approved these changes
Mar 6, 2024
|
This is out of date and a different PR did essentially the same thing already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow on PR to deal with rapidsai/cudf#15026 and NVIDIA/spark-rapids-jni#1778
Without this change once the other two PRs are merged in the plugin will start to fail because when we se the default allocator it will now end up calling back into itself recursively and blow the stack.
There is more work that would be good to do to clean things up more, but I will do that as a follow on issue.