Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spark 4.0] Address test failures in cast_test.py [databricks] #11559

Merged
merged 14 commits into from
Oct 9, 2024
Merged

[Spark 4.0] Address test failures in cast_test.py [databricks] #11559

merged 14 commits into from
Oct 9, 2024

Commits on Oct 1, 2024

  1. Spark 4: Addressed cast_test.py failures. 

    Fixes NVIDIA#11009.

This commit addresses the test failures in cast_test.py, on Spark 4.0.
These generally have to do with changes in behaviour of Spark when
ANSI mode is enabled.

This commit specifically addresses `test_cast_date_integral_and_fp`,
`test_cast_decimal_to`, and `test_cast_decimal_to_decimal`.
    @mythrocks
    mythrocks committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8210175 View commit details
    Browse the repository at this point in the history

  2. Addressed test_cast_empty_string.

    @mythrocks
    mythrocks committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2e6282b View commit details
    Browse the repository at this point in the history

  3. Addressed test_cast_float_to_timestamp*_for_nan_inf.

    @mythrocks
    mythrocks committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2a6f8fc View commit details
    Browse the repository at this point in the history

  4. Addressed test_cast_integral_to_decimal.

    @mythrocks
    mythrocks committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6a35fed View commit details
    Browse the repository at this point in the history

  5. Fixed erroneous debug line.

    @mythrocks
    mythrocks committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    dd48c61 View commit details
    Browse the repository at this point in the history

  6. Handle test_cast_timestamp_to_numeric_non_ansi.

    @mythrocks
    mythrocks committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    24d3254 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Handled test_cast_string_date_valid_format_*.

    @mythrocks
    mythrocks committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e4ecbde View commit details
    Browse the repository at this point in the history

  2. Addressed test_cast_string_ts_valid_format.

    @mythrocks
    mythrocks committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    80e97da View commit details
    Browse the repository at this point in the history

  3. Addressed test_cast_date_integral_and_fp.

    @mythrocks
    mythrocks committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    eeeb4a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Removed debug code. 

    Signed-off-by: MithunR <[email protected]>
    @mythrocks
    mythrocks committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b7879b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Change boolean constants from String to Bool.

    @mythrocks
    mythrocks committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5c4de86 View commit details
    Browse the repository at this point in the history

  2. Changed test description to reflect ANSI (non)compliance.

    @mythrocks
    mythrocks committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    bdfa3ff View commit details
    Browse the repository at this point in the history

  3. Handled test_cast_timestamp_to_numeric_non_ansi for db14.3.

    @mythrocks
    mythrocks committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    04eda7b View commit details
    Browse the repository at this point in the history

  4. Changed "true" to True.

    @mythrocks
    mythrocks committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    aa89303 View commit details
    Browse the repository at this point in the history