Fix skipping fixed_length_char ORC tests on [databricks] > 13.3 #11652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#11528. This commit addresses the failure of `orc_test.py::test_project_fallback_when_reading_hive_fixed_length_char` when run on Databricks 13.3+. This test was skipped with an incorrect reason statement in NVIDIA#9646, to address a failure on Databricks 13.3. That failure was not the result of a data mismatch. It failed because the ProjectExec didn't fall back to CPU. (In fact, with Databricks 13.3 onwards, the ProjectExec is not involved in `SELECT *` queries.) As an aside, the same test is now skipped on Databricks 13.3 and 14.3, because the error condition it tests does not fire on those versions. Signed-off-by: MithunR <[email protected]>
|
Build |
razajafri
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11528.
This commit addresses the failure of
orc_test.py::test_project_fallback_when_reading_hive_fixed_length_charwhen run on Databricks 13.3+.This test was skipped with an incorrect reason statement in #9646, to address a failure on Databricks 13.3. That failure was not the result of a data mismatch. It failed because the ProjectExec didn't fall back to CPU. (In fact, with Databricks 13.3 onwards, the ProjectExec is not involved in
SELECT *queries.)As an aside, the same test is now skipped on Databricks 13.3 and 14.3, because the error condition it tests does not fire on those versions.