Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orc_write_test.py for [databricks] 14.3 #11664

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

mythrocks
Copy link
Collaborator

Fixes #11529.

This commit fixes the failure of
orc_write_test.py::test_orc_do_not_lowercase_columns as described in #11529.

The failure was the result of a change in the exception text in Databricks 14.3. (It differs from Spark 3.5, on which it is based, and more closely resembles Spark 4.0.)

Fixes NVIDIA#11529.

This commit fixes the failure of
`orc_write_test.py::test_orc_do_not_lowercase_columns` as described
in NVIDIA#11529.

The failure was the result of a change in the exception text in
Databricks 14.3. (It differs from Spark 3.5, on which it is based, and
more closely resembles Spark 4.0.)

Signed-off-by: MithunR <[email protected]>
@mythrocks mythrocks self-assigned this Oct 25, 2024
@mythrocks mythrocks added the test Only impacts tests label Oct 25, 2024
@mythrocks
Copy link
Collaborator Author

Build

@mythrocks
Copy link
Collaborator Author

Sorting the test failure out now. Applying the patch on main seems to have messed up the imports, I think.

Signed-off-by: MithunR <[email protected]>
@mythrocks
Copy link
Collaborator Author

Build

@mythrocks mythrocks merged commit a6c4b34 into NVIDIA:branch-24.12 Oct 29, 2024
47 checks passed
@mythrocks
Copy link
Collaborator Author

Thank you for the review, @revans2. I've merged this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ORC write tests on Databricks 14.3
2 participants