Fix Parquet Writer tests on [databricks] 14.3 #11673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#11534. This commit fixes the test failures in `parquet_write_test.py`, as listed on NVIDIA#11534. This is an extension of the changes made in NVIDIA#11615, which attempted to address similar failures on Apache Spark 4. Most of the test failures pertain to legacy Parquet writer settings and conf keys which were removed on Spark 4. A stray test involves a change in how the test gleans description strings from exceptions. Signed-off-by: MithunR <[email protected]>
|
Build |
|
Build |
mythrocks
changed the title
razajafri
reviewed
Nov 4, 2024
Signed-off-by: MithunR <[email protected]>
|
Build |
|
@razajafri, I've moved the tests over to use the new conf names. Good suggestion. This reduces the code on the test-side. If this is agreeable, shall we check this in? (We'll ignore the failure against Spark 4.0 for the moment.) |
revans2
approved these changes
Nov 6, 2024
|
Thank you for the reviews, @revans2, @razajafri. I've merged this change as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11534.
This commit fixes the test failures in
parquet_write_test.py, as listed on #11534.This is an extension of the changes made in #11615, which attempted to address similar failures on Apache Spark 4.
Most of the test failures pertain to legacy Parquet writer settings and conf keys which were removed on Spark 4. A stray test involves a change in how the test gleans description strings from exceptions.