Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spark 3.4.4 Shim #11692

Merged
merged 11 commits into from
Nov 6, 2024
Merged

Add Spark 3.4.4 Shim #11692

merged 11 commits into from
Nov 6, 2024

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented Nov 4, 2024

  • Fix shimplify to execute mvn generate-sources -Dshimplify=true -Dshimplify.move=true -Dshimplify.overwrite=true -Dshimplify.add.shim=344 -Dshimplify.add.base=343 -s jenkins/settings.xml

Closes #11662

gerashegalov and others added 5 commits November 4, 2024 11:17
Signed-off-by: Gera Shegalov <[email protected]>
- cleanup aggregator

Signed-off-by: Gera Shegalov <[email protected]>
- create a parametrizable delta-lake dependency
- use profiles only to add extra delta-lake dependencies

Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov gerashegalov self-assigned this Nov 4, 2024
@gerashegalov gerashegalov added the feature request New feature or request label Nov 4, 2024
@gerashegalov gerashegalov changed the title Add Spark 3.4.4 Shim Add Spark 3.4.4 Shim [databricks] Nov 4, 2024
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov
Copy link
Collaborator Author

400 failure is a known issue
344 is waiting for spark-rapids-private

@gerashegalov
Copy link
Collaborator Author

build

Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov
Copy link
Collaborator Author

build

aggregator/pom.xml Outdated Show resolved Hide resolved
razajafri
razajafri previously approved these changes Nov 5, 2024
Copy link
Collaborator

@razajafri razajafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides Jason's comment, LGTM

@gerashegalov gerashegalov changed the title Add Spark 3.4.4 Shim [databricks] Add Spark 3.4.4 Shim Nov 6, 2024
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov merged commit ddbbba3 into NVIDIA:branch-24.12 Nov 6, 2024
46 of 49 checks passed
@gerashegalov gerashegalov deleted the spark344 branch November 6, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Support Apache Spark 3.4.4
3 participants