Fix spark400 build due to LogicalRelation signature changes [databricks] #11695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
|
build |
razajafri
approved these changes
Nov 5, 2024
|
Hey, thanks for picking this up, @jlowe. I was about to raise a PR for this. I do like yours better. |
mythrocks
approved these changes
Nov 5, 2024
|
build |
gerashegalov
reviewed
Nov 6, 2024
Comment on lines
-86
to
+87
| sparkSession.table(tableIdent).queryExecution.analyzed.collect { | ||
| case LogicalRelation(t: HadoopFsRelation, _, _, _) => t.location | ||
| }.head | ||
| LogicalPlanShims.getLocations(sparkSession.table(tableIdent).queryExecution.analyzed).head |
There was a problem hiding this comment.
It is not a nice Scala but I recommend to future-proof and avoid small shim burden:
val fileIndex = catalogTable.map(_.identifier).map { tableIdent =>
sparkSession.table(tableIdent).queryExecution.analyzed.collect {
case lr: LogicalRelation if lr.relation.isInstanceOf[HadoopFsRelation] =>
lr.relation.asInstanceOf[HadoopFsRelation].location
}.head
}There was a problem hiding this comment.
I considered this at first, but I'm not sure this is "future-proof." I think we'd rather prefer to have the compiler and/or runtime inform us if a Spark platform changed this interface, since we may need to do more than just ignore the added parameters. In those cases Spark would have to change this corresponding code, and we would need to change it in a compatible way. Maybe that change is to ignore the added or removed parameters, maybe not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11684. SPARK-50144 added a new parameter to LogicalRelation, breaking old unapply usages. Added a new shim for gathering the locations for a logical plan which was the one place using LogicalRelation.unapply.