Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leak with RapidsHostColumnBuilder in GpuUserDefinedFunction #11700

Open
wants to merge 1 commit into
base: branch-24.12
Choose a base branch
from
Open

Fix leak with RapidsHostColumnBuilder in GpuUserDefinedFunction #11700

wants to merge 1 commit into from

Conversation

abellina
Copy link
Collaborator

@abellina abellina commented Nov 6, 2024

This is a small leak in GpuUserDefinedFunction now that RapidsHostColumnBuilder needs to be closed, since build increases the ref count, for retry purposes.

@abellina abellina requested a review from revans2 November 6, 2024 15:21
@abellina
Copy link
Collaborator Author

abellina commented Nov 6, 2024

build

revans2
revans2 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abellina @revans2