impalaFile cannot be found by UT framework. #11707
Open
+120
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fejiang <[email protected]>
Signed-off-by: fejiang <[email protected]>
|
build |
thirtiseven
previously approved these changes
Nov 7, 2024
| class RapidsParquetInteroperabilitySuite | ||
| extends ParquetInteroperabilitySuite | ||
| with RapidsSQLTestsBaseTrait {} | ||
| with RapidsSQLTestsBaseTrait { | ||
| test("parquet timestamp conversion in Rapids"){ |
There was a problem hiding this comment.
nit: use testRapids("parquet timestamp conversion") or test("parquet timestamp conversion Rapids") { ?
Signed-off-by: fejiang <[email protected]>
Signed-off-by: fejiang <[email protected]>
|
build |
revans2
approved these changes
Nov 7, 2024
| @@ -77,7 +77,7 @@ class RapidsTestSettings extends BackendTestSettings { | |||
| enableSuite[RapidsParquetFieldIdSchemaSuite] | |||
| enableSuite[RapidsParquetInteroperabilitySuite] | |||
| .exclude("SPARK-36803: parquet files with legacy mode and schema evolution", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/11454")) | |||
| .exclude("parquet timestamp conversion", KNOWN_ISSUE("https://github.com/NVIDIA/spark-rapids/issues/11448")) | |||
| .exclude("parquet timestamp conversion", ADJUST_UT("impala_timestamp cannot be found")) | |||
There was a problem hiding this comment.
So just to be clear her the ADJUST_UT means that the test cannot pass so we wrote a new test to cover the same thing?
There was a problem hiding this comment.
Yes, the old one need to be exclued from the suites ParquetInteroperabilitySuite which RapidsParquetInteroperabilitySuite inherites. In this case, the impala_timestamp file cannot be found by the way used in the old test case, so I changed some code to enable impala_timestamp to be found and put it in ParquetInteroperabilitySuite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11448
This pr is for "parquet timestamp conversion" test case, that couldn't load test-data/impala_timestamp.parq from class path.