Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Don't specialize is_system_tag for host_system_tag when compiling for device #1691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ericniebler
Copy link
Collaborator

No description provided.

@ericniebler ericniebler added type: bug: functional Does not work as intended. P0: must have Absolutely necessary. Critical issue, major blocker, etc. labels May 16, 2022
@ericniebler ericniebler requested a review from alliepiper May 16, 2022 22:41
@ericniebler
Copy link
Collaborator Author

run tests

Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a comment explaining why this specialization is disabled, but LGTM.

@alliepiper
Copy link
Collaborator

Looks like there are some new failures that will need to be addressed before merging.

@alliepiper alliepiper added this to the 2.1.0 milestone Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P0: must have Absolutely necessary. Critical issue, major blocker, etc. type: bug: functional Does not work as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants