Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: example scripts - additional dependencies? #3

Closed
AlexanderFabisch opened this issue Dec 3, 2024 · 1 comment
Closed

Comments

@AlexanderFabisch
Copy link
Contributor

When running the example scripts on my computer (after pip install with [all]), I get the following errors:

$ python examples/stable_poses.py 
ValueError: string is not a file: /home/clemens/code/scene_synthesizer/tests/data/assets/shapenetsem_watertight/Mug/b46a9c35587a38f6e87dab59b7e63362.obj

$ python examples/isaaclab_kitchen_env_cfg.py
NameError: name 'configclass' is not defined

$ python examples/add_random_mdl_materials.py 
ModuleNotFoundError: No module named 'xatlas'

I guess there are some dependencies missing? (+ hardcoded path)

openjournals/joss-reviews#7561

@clemense
Copy link
Collaborator

clemense commented Dec 3, 2024

Thanks!

In the latest update (c292bf8) I addressed all three issues:

  • I removed the hardcoded path from examples/stable_poses.py
  • I removed the file example/isaaclab_kitchen_env_cfg.py since it's not a self-contained runnable example, it was only used as a literalinclude in https://scene-synthesizer.github.io/examples/isaaclab_rl.html. I instead added it to the rst file directly.
  • I added the missing dependency to the setup.cfg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants