modify sim_ber callback to include all results #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR. I have a two open points:
|
|
I've made the requested changes. Is the PR now complete? I am new to git, not sure if I need to take any further action. |
|
I did some minor edits, the PR is now ready. We will merge into the next release of Sionna. Thank you for your contribution. |
SebastianCa
approved these changes
Dec 21, 2023
|
Hi @nbecker , thanks for the contributions. Can you please reply here in the conversation with the code signoff? I can then add it to the merge commit. |
|
I've done Hopefully everything is good now? |
|
thanks for the prompt reply. Unfortunately, the commit does not seems to be signed-off: but do not worry. If you just paste the sign-off here I will add it. |
|
Signed-off-by: Neal Becker ***@***.***>
…On Tue, Jan 9, 2024 at 7:59 AM Guillermo Marcus ***@***.***> wrote:
thanks for the prompt reply. Unfortunately, the commit does not seems to
be signed:
commit 6e112a9 (HEAD -> main, origin/main, origin/HEAD)
Merge: cf745b4 be78a0d
Author: ndbecker ***@***.***>
Date: Tue Jan 9 07:04:47 2024 -0500
Merge branch 'main' into main
but do not worry. If you just paste the sign-off here I will add it.
—
Reply to this email directly, view it on GitHub
<#286 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA4VUASNWL42UXFA4HUFD3YNU5MZAVCNFSM6AAAAABARL4NKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTGAZDINRVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Those who don't understand recursion are doomed to repeat it*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass all stats to sim_ber callback so they can be used to log results for all es/no points
Describe what was wrong, and explain the solution in detail.
Describe the new feature, ensure that it is properly documented. Note that for new features unit tests are required.
Address in detail why it is needed. Explain and describe the consequences, does it break older code? Note that API changes might be delayed until a major bump release for inclusion.
Please detail the nature of the submission.
Checklist
[ ] Detailed description
[ ] Added references to issues and discussions
[ ] Added / modified documentation as needed
[ ] Added / modified unit tests as needed
[ ] Passes all tests
[ ] Lint the code
[ ] Performed a self review
[ ] Ensure you Signed-off the commits. Required to accept contributions!
[ ] Co-authored with someone? Add Co-authored-by: user@domain and ensure they signed off their commits too.