Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibilty for tensorflow-v2 #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

compatibilty for tensorflow-v2 #19

wants to merge 3 commits into from

Conversation

ertza
Copy link

@ertza ertza commented Apr 25, 2021

pip only allows tensorflow>=2.2.0. This commit makes the code compatible to work with those versions.

@alkanen
Copy link

alkanen commented May 10, 2021

Why are the pyc files included? They are generated when you run python, they shouldn't be checked in.

@alkanen
Copy link

alkanen commented May 10, 2021

The same goes for the gazillian dataset files. They're not part of the code base, and some of them are huge.
And you've included images as well.

Did you just do "git add *" in the working directory?

Copy link

@alkanen alkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be merged. The code changes might be fine, but the ~90 completely unrelated files that shouldn't be here to begin with aren't.

@ertza
Copy link
Author

ertza commented May 10, 2021

Sorry these commits are not to be pulled into the main branch, they are a custom commit for my mirror of the repo. Only the first one was the one intended to be a pull request. Please ignore the other commits.

@alkanen
Copy link

alkanen commented May 10, 2021

Sorry these commits are not to be pulled into the main branch, they are a custom commit for my mirror of the repo. Only the first one was the one intended to be a pull request. Please ignore the other commits.

Gotcha! Then please disregard my rather harsh comments :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants