Update Testing Docs #149
Update Testing Docs #149
Conversation
|
|
||
| def setUp(self): | ||
| self.mm = ModuleManager() | ||
| nwchemex.load_modules(mm) # Also loads out SCF modules |
There was a problem hiding this comment.
Fine for now, but not sure this is going to work in practice. In particular, I'm not convinced it will find the SCF version we want to test vs. the release version NWX depends on. We can worry about that later though.
There was a problem hiding this comment.
I wondered about that, as well. My expectation is that the version that is being built at the time should be found by CMake, so it shouldn't try to pull and build the version specified within NWChemEx. I think it should also take precedent over installed versions, but I'm not sure.
There was a problem hiding this comment.
I think it's going to depend on the Python path order if there's an installed version competing with the just built version. An "easy" way around this is:
import scf # Ensure import of this repo
import nwchemex
self.mm = ModuleManager()
scf.load_modules(mm)
nwchemex.load_modules(mm)The trick would be to make sure that load_modules is a no-op if the keys already exist.
There was a problem hiding this comment.
It's also worth noting this only an issue for NWChemEx authors. Contributors don't have their plugins shipped with NWChemEx.
|
🚀 [bumpr] Bumped! New version:v0.3.44 Changes:v0.3.43...v0.3.44 |
Description
This PR fills in some of the missing documentation on testing.