fix remaining warnings

NWChemEx · May 13, 2024 · ccb7fcf · ccb7fcf
1 parent d969894
commit ccb7fcf
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/include/pluginplay/fields/module_input.ipp b/include/pluginplay/fields/module_input.ipp
@@ -19,7 +19,7 @@
 namespace pluginplay {
 
 inline ModuleInput& ModuleInput::operator=(const ModuleInput& rhs) {
-    return *this = std::move(ModuleInput(rhs));
+    return *this = ModuleInput(rhs);
 }
 
 template<typename T>
@@ -118,7 +118,7 @@ auto& ModuleInput::change(T&& new_value) {
     // By convention we store strings as std::string, so we have to catch when
     // the user passed a C-string in
     if constexpr(detail_::IsCString<T>::value) {
-        change_(std::move(wrap_value_(std::string(new_value))));
+        change_(wrap_value_(std::string(new_value)));
     } else {
         change_(std::move(wrap_value_(std::forward<T>(new_value))));
     }

diff --git a/include/pluginplay/fields/module_result.ipp b/include/pluginplay/fields/module_result.ipp
@@ -22,7 +22,7 @@ namespace pluginplay {
 //------------------------------Implementations---------------------------------
 
 inline ModuleResult& ModuleResult::operator=(const ModuleResult& rhs) {
-    return *this = std::move(ModuleResult(rhs));
+    return *this = ModuleResult(rhs);
 }
 
 template<typename T>
@@ -44,7 +44,7 @@ void ModuleResult::change(T&& new_value) {
     if constexpr(is_shared_any)
         change_(new_value);
     else if constexpr(detail_::IsCString<T>::value)
-        change_(std::move(wrap_value_(std::string(new_value))));
+        change_(wrap_value_(std::string(new_value)));
     else
         change_(std::move(wrap_value_(std::forward<T>(new_value))));
 }

diff --git a/include/pluginplay/submodule_request.hpp b/include/pluginplay/submodule_request.hpp
@@ -441,7 +441,7 @@ class SubmoduleRequest {
 
 inline SubmoduleRequest& SubmoduleRequest::operator=(
   const SubmoduleRequest& rhs) {
-    return *this = std::move(SubmoduleRequest(rhs));
+    return *this = SubmoduleRequest(rhs);
 }
 
 template<typename T>

diff --git a/src/pluginplay/detail_/module_manager_pimpl.hpp b/src/pluginplay/detail_/module_manager_pimpl.hpp
@@ -167,7 +167,7 @@ struct ModuleManagerPIMPL {
      */
     void copy_module(const type::key& old_key, type::key new_key) {
         assert_unique_key_(new_key);
-        Module mod = std::move(m_modules.at(old_key)->unlocked_copy());
+        Module mod = m_modules.at(old_key)->unlocked_copy();
         auto ptr   = std::make_shared<Module>(std::move(mod));
         ptr->set_name(new_key);
         m_modules.emplace(std::move(new_key), ptr);