Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac debug #346

Merged
merged 4 commits into from
May 3, 2024
Merged

Mac debug #346

merged 4 commits into from
May 3, 2024

Conversation

jwaldrop107
Copy link
Member

@jwaldrop107 jwaldrop107 commented May 2, 2024

Is this pull request associated with an issue(s)?
Resolves #311 (at least, it compiles on my non-Apple Silicon Mac using Apple Clang)

Description
The problem in #311 seems to derive from the difference in the implementation for typeinfo between libstdc++ and libc++ and the effect that has on any_cast-ing with shared libraries. Here are some stackoverflow threads (1,2) relating to the topic, but trying to succinctly describe it is beyond me at the moment. Using boost::any seems to be a more portable way of handling the type erasure in the AnyField and PythonWrapper classes, so this PR swaps the usage of std::any for boost::any.

@jwaldrop107 jwaldrop107 self-assigned this May 2, 2024
@jwaldrop107 jwaldrop107 requested a review from yzhang-23 May 3, 2024 01:32
@jwaldrop107 jwaldrop107 enabled auto-merge May 3, 2024 01:32
@jwaldrop107 jwaldrop107 merged commit 5900642 into master May 3, 2024
5 checks passed
@jwaldrop107 jwaldrop107 deleted the mac_debug branch May 3, 2024 13:40
@jwaldrop107
Copy link
Member Author

🚀 [bumpr] Bumped! New version:v1.0.33 Changes:v1.0.32...v1.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python unit test failure with Apple Clang
3 participants