Skip to content

Commit

Permalink
ppc/kvm: Register also a generic spapr CPU core family type
Browse files Browse the repository at this point in the history
RH-Author: Thomas Huth <[email protected]>
Message-id: <[email protected]>
Patchwork-id: 71897
O-Subject: [RHEL-7.3 qemu-kvm-rhev PATCH 5/5] ppc/kvm: Register also a generic spapr CPU core family type
Bugzilla: 1363812
RH-Acked-by: Laurent Vivier <[email protected]>
RH-Acked-by: David Gibson <[email protected]>
RH-Acked-by: Miroslav Rezanina <[email protected]>

There is a regression with the "-cpu" parameter introduced by
the spapr CPU hotplug code: We used to allow to specify a
"CPU family" name with the "-cpu" parameter when running on KVM so
that the user does not need to know the gory details of the exact
CPU version of the host CPU. For example, it was possible to
use "-cpu POWER8" on a POWER8E host CPU. This behavior does not
work anymore with the new hot-pluggable spapr-cpu-core types.
Since libvirt already heavily depends on the old behavior, this
is quite a severe regression in the QEMU parameter interface.
Let's fix it by supporting a CPU family type for the spapr-cpu-core
on KVM, too.

Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1363812
Signed-off-by: Thomas Huth <[email protected]>
Signed-off-by: David Gibson <[email protected]>
(cherry picked from commit d11b268)
Signed-off-by: Miroslav Rezanina <[email protected]>
  • Loading branch information
huth authored and cuinutanix committed Mar 9, 2017
1 parent 0386012 commit cad253b
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions target-ppc/kvm.c
Original file line number Diff line number Diff line change
Expand Up @@ -2410,8 +2410,11 @@ static int kvm_ppc_register_host_cpu_type(void)
type_info.class_init = NULL;
type_register(&type_info);
g_free((void *)type_info.name);
type_info.instance_size = 0;
type_info.instance_init = NULL;

/* Register generic spapr CPU family class for current host CPU type */
type_info.name = g_strdup_printf("%s-"TYPE_SPAPR_CPU_CORE, dc->desc);
type_register(&type_info);
g_free((void *)type_info.name);
#endif

return 0;
Expand Down

0 comments on commit cad253b

Please sign in to comment.