Skip to content

Commit

Permalink
Removes Helvetica, updates README (#149)
Browse files Browse the repository at this point in the history
* Removes Helvetica, updates README

* Tweaks README
  • Loading branch information
oliviawongnyc authored Feb 1, 2023
1 parent 9314d36 commit e6adb05
Show file tree
Hide file tree
Showing 25 changed files with 10 additions and 2,075 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ Most styling is included in the basic UI, but we also ship a few css files that
1. Both the HTML and the PDF side have css that is necessary to be included for the dependencies we use to render correctly. This is built automatically into `@nypl/web-reader/dist/esm/index.css` and `@nypl/web-reader/dist/cjs/index.css`. Depending which package you are using, you should include one of those files in your bundle.
1. The HTML Reader can inject `<style>` tags (and other tags) into the reader iframe itself, called an "injectable". This is used to add styles to the html content of the publication. More on this is below.

In order for the Settings panel to be displayed as intended, the fonts Roboto, Georgia, Helvetica, and OpenDyslexic must be available to your application. Georgia is web safe, meaning it is installed by default on most devices, but the others are not. One way to include them is to copy the `fonts` folder and its contents from `@nypl/web-reader/example/static` into your `/public` directory.
In order for the Settings panel to be displayed as intended, the fonts Roboto, Georgia, and OpenDyslexic must be available to your application. Georgia is web safe, meaning it is installed by default on most devices, but the others are not. One way to include them is to copy them from the `fonts` folder in `@nypl/web-reader/example/static` into your `/public` directory. Alternatively, for Roboto, you can embed the Google Font into the <head> of your html (directions [here](https://fonts.google.com/specimen/Roboto)).

## Injectables

Expand Down
6 changes: 6 additions & 0 deletions example/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta http-equiv="X-UA-Compatible" content="ie=edge" />
<link rel="preconnect" href="https://fonts.googleapis.com" />
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
<link
href="https://fonts.googleapis.com/css2?family=Roboto:wght@300&display=swap"
rel="stylesheet"
/>
<title>NYPL Web Reader Example</title>
</head>

Expand Down
Binary file removed example/static/fonts/helvetica/Helvetica.eot
Binary file not shown.
Binary file removed example/static/fonts/helvetica/Helvetica.ttf
Binary file not shown.
Binary file removed example/static/fonts/helvetica/Helvetica.woff
Binary file not shown.
Binary file removed example/static/fonts/helvetica/Helvetica.woff2
Binary file not shown.
11 changes: 0 additions & 11 deletions example/static/fonts/helvetica/helvetica.css

This file was deleted.

203 changes: 0 additions & 203 deletions example/static/fonts/roboto/Apache License.txt

This file was deleted.

Loading

1 comment on commit e6adb05

@vercel
Copy link

@vercel vercel bot commented on e6adb05 Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

web-reader – ./

web-reader-git-main-nypl.vercel.app
web-reader-nypl.vercel.app
nypl-web-reader.vercel.app

Please sign in to comment.