Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiger team feature #1457

Open
wants to merge 146 commits into
base: qa
Choose a base branch
from
Open

Tiger team feature #1457

wants to merge 146 commits into from
+3,475 −3,385

Conversation

croyfish
Copy link
Member

@croyfish croyfish commented Oct 28, 2024 •
edited
Loading

JIRA tickets:

Things Done:

  • Upgraded Ruby (to 3.3), gem dependencies, and Node (to 20.x)
  • Implemented Docker + docker compose for local development
  • Renamed the local environment to development and deprecated code related to the vestigial Elastic Beanstalk development environment
  • Replaced Travis CI with GitHub Actions
  • Made unit tests run automatically on PRs against protected branches (qa / production)

How to Test:

  • The build builds and the unit tests pass
  • docker-compose build
  • docker-compose up
  • The app behaves as expected at http://localhost:3000

croyfish and others added 30 commits September 25, 2024 17:08
@croyfish
WIP setting up docker compose
6ec3f85
@croyfish
update yarn lockfile
2b6ec21
@croyfish
Merge branch 'qa' into TGR-112-upgrade-investigations
d900d49
@croyfish
more WIP changes
3d58d32
@croyfish
Merge branch 'qa' into TGR-112-upgrade-investigations
d662acc
@croyfish
add example env file
ee07608
@croyfish
Merge branch 'tiger-team-feature' into TGR-112-upgrade-investigations
090e3bc
@croyfish
WIP commit
a2b05b0
@croyfish
update service names locally
dcc1695
@croyfish
Merge branch 'TGR-112-upgrade-investigations' into TGR-112-upgrade-de…
f0540ff 
…pendencies
@croyfish
add rpsec to gemfiles
e5ba209
@croyfish
change exists to exist
65490df
@croyfish
change local to development
ca4a68b
@croyfish
change a couple more files
50474da
@croyfish
more changes to make stuff work locally
24728ad
@croyfish
make puma start in deployed environments as well
82e459a
@croyfish
remove comments
7bc2d7d
@croyfish
remove another comment
59a6fc6
@croyfish
remove another coment
e5673e6
@croyfish
Merge pull request #1436 from NYPL/TGR-112-upgrade-investigations
e3526b3 
TGR 112 implement docker compose
@croyfish
Merge branch 'qa' into tiger-team-feature
b356df0
@croyfish
Merge branch 'tiger-team-feature' into TGR-118-convert-local-to-devel…
052bcb5 
…opment
@croyfish
cleaning up
9c74ad0
@croyfish
update db service names
3867e07
@croyfish
Merge branch 'TGR-118-convert-local-to-development' into TGR-117-add-…
0d65554 
…rspec-coverage
@croyfish
set up and begin
644631f
@croyfish
add books specs
7582d0d
@croyfish
add home specs
1b0e402
@croyfish
got some hold specs going
a4c5d46
@croyfish
good progress on fixing minitests
66463d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@croyfish @gonuguntla @deepikagonuguntla