Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-1718v2_AutoIngestionLOC #266

Merged
merged 5 commits into from
Aug 29, 2023
Merged

SFR-1718v2_AutoIngestionLOC #266

merged 5 commits into from
Aug 29, 2023

Conversation

mitri-slory
Copy link
Contributor

This PR focuses on adding automatic ingestion for the LOC items. This auto ingestion will be weekly instead of daily due to the LOC site not being as updated consistently compared to other sources in DRB.

@mwbenowitz mwbenowitz temporarily deployed to Tugboat July 20, 2023 20:49 Destroyed
Copy link
Contributor

@sarangj sarangj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! One suggestion on some of the timestamp logic, but otherwise makes sense (and I know you're still figuring out the epub thing)

@mwbenowitz mwbenowitz temporarily deployed to Tugboat July 21, 2023 16:21 Destroyed
@mwbenowitz mwbenowitz temporarily deployed to Tugboat August 23, 2023 16:34 Destroyed
@mwbenowitz mwbenowitz temporarily deployed to Tugboat August 29, 2023 16:05 Destroyed
@sarangj sarangj self-requested a review August 29, 2023 16:18
Copy link
Contributor

@sarangj sarangj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions / suggestions, feel free to apply / ignore as makes sense to you!

@mwbenowitz mwbenowitz temporarily deployed to Tugboat August 29, 2023 16:44 Destroyed
@mitri-slory mitri-slory merged commit 8472433 into main Aug 29, 2023
@mitri-slory mitri-slory deleted the SFR-1718v2_AutoIngestionLOC branch August 29, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants