Sfr 1829 complete fulfill endpoint #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitri-slory
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request completes the fulfill endpoint. It also refactors the fulfill endpoint in order to fix control flow and error issues. The fulfill endpoint blueprint is now called "itemFulfill" because it fulfills items, not works, and uses a link ID as its identifier.
Motivation and Context
This work is needed in order to return pre-signed URLs from the fulfill endpoint. Additionally, it includes some updates to the DB client code and a slightly different structure from the other blueprints that utilize the DB in an effort to reduce hanging database connections if an unexpected error occurs.