SFR-1775_University Michigan Ingestion #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apophenia
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Hi Dmitri, I think this looks good, I just have questions for my own reference about the "_100pct.pdf" convention here. Is it the case that all of the items in the bucket have either "_100pct.pdf" or "_060pct.pdf" appended and we just check to see which one appears in the bucket for any given title? Do some of the titles have both (if you happen to know)?
Apophenia
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a process and mapping for the University of Michigan books. It also includes unit tests for the process and mapping as well.