Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2079: Integration test make command #316

Merged
merged 5 commits into from
Jul 30, 2024
Merged

SFR-2079: Integration test make command #316

merged 5 commits into from
Jul 30, 2024

Conversation

kylevillegas93
Copy link
Contributor

@kylevillegas93 kylevillegas93 commented Jul 30, 2024 •
edited
Loading

Description

  • Adds integration test make command

Testing

make unit; make integration

TODO

  • We will tackle integration tests and CI in a later phase of tech debt but not as part of the OCLC work.

@kylevillegas93 kylevillegas93 changed the title SFR-2079: Integration test action SFR-2079: Integration test make command Jul 30, 2024
Apophenia
Apophenia approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Apophenia Apophenia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes, looks good!

@kylevillegas93 kylevillegas93 merged commit c349bc7 into main Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apophenia Apophenia Apophenia approved these changes

@mitri-slory mitri-slory Awaiting requested review from mitri-slory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @Apophenia