SFR-2179/get_collection_list #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ayan1229
commented
Sep 23, 2024
ayan1229
commented
- This PR validates the api response for a query that returns collection list by title.
- it also verifies that when the API is hit, it doesn't return an empty JSON body in response
| @@ -19,4 +19,4 @@ def test_get_collection(): | |||
|
|
|||
| response_json = response.json() | |||
|
|
|||
| assert response_json is not None | |||
| assert response_json is not None | |||
There was a problem hiding this comment.
nit: new line at eof
tests/rest_api/test_get_list.py
Outdated
|
|
||
| response_json = response.json() | ||
|
|
||
| assert response_json is not None |
There was a problem hiding this comment.
nit: new line at eof
There was a problem hiding this comment.
do you always want to keep an empty line at the end? or no lines
There was a problem hiding this comment.
always a new line that is empty at the end of the file!
tests/rest_api/test_get_list.py
Outdated
There was a problem hiding this comment.
hmm is test_get_list explicit?
There was a problem hiding this comment.
renaming to test_get_collection_list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.