SFR-2105: Deprecate OCLC Classify Manager #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| mockCheckRedis.assert_called_once_with('classifyWork', '1', 'owi') | ||
| def test_get_queryable_identifiers(self): | ||
| assert ClassifyProcess._get_queryable_identifiers(['1|isbn', '2|test']) == ['1|isbn'] |
There was a problem hiding this comment.
nit: newline at the end of this test!
kylevillegas93
approved these changes
Sep 26, 2024
processes/oclcClassify.py
Outdated
| return self.checkSetRedis('classifyWork', workOWI, 'owi') | ||
| def _get_queryable_identifiers(identifiers): | ||
| return list(filter( | ||
| lambda x: re.search(r'\|(?:isbn|issn|oclc)$', x) != None, |
There was a problem hiding this comment.
nit: x is very generic, we could use identifier or id to be specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions were unused, but represent logic that was recreated in the Classify process (e.g. the "v2" metadata fetch function) and would benefit from new tests. Other portions of the removed logic seem to already be covered by new mapping tests.