Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2217 Fixing MUSE Mapping #385

Merged
merged 7 commits into from
Oct 3, 2024
Merged

SFR-2217 Fixing MUSE Mapping #385

merged 7 commits into from
Oct 3, 2024

Conversation

kylevillegas93
Copy link
Contributor

@kylevillegas93 kylevillegas93 commented Oct 1, 2024 •
edited
Loading

Description

  • Cleanup OCLC no prefix from Muse mapping
  • Fixed language extraction
  • Fixed ids with leading/trailing whitespace

Testing

make unit

mitri-slory
mitri-slory approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cleanup of the muse mapping looks good.

@kylevillegas93 kylevillegas93 changed the title SFR-2217 Cleanup OCLC no prefix SFR-2217 Fixing MUSE Mapping Oct 3, 2024
mitri-slory
mitri-slory approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes to the mapping look good and the examples you sent in Slack looked to have fixed the formatting for values in the languages and identifiers fields.

@kylevillegas93 kylevillegas93 merged commit ae9a953 into main Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitri-slory mitri-slory mitri-slory approved these changes

@Apophenia Apophenia Awaiting requested review from Apophenia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @mitri-slory