Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2216: Fixing NYPL ingest process locally #393

Merged
merged 1 commit into from
Oct 7, 2024
Merged

SFR-2216: Fixing NYPL ingest process locally #393

merged 1 commit into from
Oct 7, 2024

Conversation

kylevillegas93
Copy link
Contributor

Description

  • SQLAlchemy is returning a tuple and not a JSON as per the original code.
  • I added a _map_bib function that will try to unpack a tuple first and then default to the bib.
  • Streamlined the query to only return fields we are interested in

Testing

python main.py -p NYPLProcess -e local -i complete -l 10

mitri-slory
mitri-slory approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good changes here!

@kylevillegas93 kylevillegas93 merged commit daf7bba into main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitri-slory mitri-slory mitri-slory approved these changes

@Apophenia Apophenia Awaiting requested review from Apophenia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @mitri-slory