SFR-2247: Fixing deep copy work identifiers bug #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitri-slory
changed the title
|
After running this locally with the changes in place, I no longer see the errors in the developer setup process. It makes sense to me that this might fix the error, since SQLAlchemy manages both the original custom data structure and the Instance objects in it. |
kylevillegas93
approved these changes
Oct 15, 2024
mitri-slory
changed the title
mitri-slory
deleted the
NO-REF--Deep-to-Shallow-copy-of-WorkIdentifiers-array
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hotfix PR is meant to fix a bug when making a deep copy of the workIdentifiers array since there are Instance objects and deep copy isn't naturally designed to make copies of Instance objects. In this case, it would be better to make a new array that references the Instance objects instead with a shallow copy.