Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-2256: Refactoring API Process #401

Merged
merged 3 commits into from
Oct 21, 2024
Merged

SFR-2256: Refactoring API Process #401

merged 3 commits into from
Oct 21, 2024

Conversation

kylevillegas93
Copy link
Contributor

Description

  • Refactors API Process and tests
  • Moves to composition rather than inheritance
  • Adds error handling and logging

Testing

make test; docker compose up

Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@kylevillegas93 kylevillegas93 merged commit 2386334 into main Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants