Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2267: Fixing duplicate work bug #406

Merged
merged 2 commits into from
Oct 21, 2024
Merged

SFR-2267: Fixing duplicate work bug #406

merged 2 commits into from
Oct 21, 2024

Conversation

kylevillegas93
Copy link
Contributor

Description

  • Because we have a PK on id and not uuid we were not merging correctly and instead creating duplicate works with the same uuid but different ids
  • This change sets the work id as the matched work id to merge properly

Testing

`make test; python main.py -p SeedLocalDataProcess -e local (run multiple times)
Screenshot 2024-10-18 at 4 26 28 PM

mitri-slory
mitri-slory approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good bug fix and I'm glad we found this bug that was most likely present here for a long time now.

@kylevillegas93 kylevillegas93 merged commit 794ab52 into main Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitri-slory mitri-slory mitri-slory approved these changes

@Apophenia Apophenia Awaiting requested review from Apophenia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @mitri-slory