Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2291: Throw error if we fail to generate webpub #422

Merged
merged 3 commits into from
Oct 30, 2024
Merged

SFR-2291: Throw error if we fail to generate webpub #422

merged 3 commits into from
Oct 30, 2024

Conversation

kylevillegas93
Copy link
Contributor

Description

  • We don't want to silently fail to generate a webpub
  • If we can't, we should not acknowledge the message and retry the processing of the message

Testing

make unit

@kylevillegas93 kylevillegas93 marked this pull request as ready for review October 29, 2024 18:05
mitri-slory
mitri-slory approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch to make sure we see this error right away.

@kylevillegas93 kylevillegas93 changed the title SFR-22991: Throw error if we fail to generate webpub SFR-2291: Throw error if we fail to generate webpub Oct 30, 2024
@kylevillegas93 kylevillegas93 merged commit 8f62634 into main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitri-slory mitri-slory mitri-slory approved these changes

@Apophenia Apophenia Awaiting requested review from Apophenia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @mitri-slory