Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2294: Only cluster records that have a title #424

Merged
merged 6 commits into from
Oct 30, 2024
Merged

SFR-2294: Only cluster records that have a title #424

merged 6 commits into from
Oct 30, 2024

Conversation

kylevillegas93
Copy link
Contributor

Description

  • We are still seeing some NYPL records that we fail to cluster because the title is None
  • Adding a filter to filter out records where the title is None in the first place.

mitri-slory
mitri-slory approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and hopefully this fixes records with no titles being clustered.

@kylevillegas93 kylevillegas93 merged commit e425444 into main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitri-slory mitri-slory mitri-slory approved these changes

@Apophenia Apophenia Apophenia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylevillegas93 @Apophenia @mitri-slory