Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2346: Fix edition verion unpacking #457

Merged
merged 1 commit into from
Nov 22, 2024
Merged

SFR-2346: Fix edition verion unpacking #457

merged 1 commit into from
Nov 22, 2024

Conversation

kylevillegas93
Copy link
Contributor

Description

  • Some NYPL records have some different has_version columns, e.g. 2d ed.||2|2
  • These versions were causing issues while unpacking the edition statement and number
  • Updated the code to handle these cases

Testing

python main.py -p ClusterProcess -e local-qa -i daily

@kylevillegas93 kylevillegas93 merged commit c9c4d9a into main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitri-slory mitri-slory mitri-slory approved these changes

@Apophenia Apophenia Awaiting requested review from Apophenia

@samanthaandrews samanthaandrews Awaiting requested review from samanthaandrews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @mitri-slory