Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue detecting router prompt #92

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

tl-sl
Copy link
Contributor

@tl-sl tl-sl commented Jan 7, 2025

To go along with sl-web-tools update.

The buffer string containing the router prompt ('>') doesn't consistently contain newline character. Occasionally its missing and flashing will fail. So remove newline char from the string matching the prompt.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.46%. Comparing base (b009196) to head (58dcb8b).
Report is 13 commits behind head on dev.

Files with missing lines Patch % Lines
universal_silabs_flasher/router.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #92      +/-   ##
==========================================
+ Coverage   61.78%   66.46%   +4.68%     
==========================================
  Files          14       15       +1     
  Lines        1748     1822      +74     
==========================================
+ Hits         1080     1211     +131     
+ Misses        668      611      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly merged commit 448c4b3 into NabuCasa:dev Jan 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants