load testing: remove call to getConnection

NangoHQ · Feb 9, 2024 · 37a05d7 · 37a05d7
1 parent 6055a95
commit 37a05d7
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 37 deletions.
diff --git a/packages/server/lib/controllers/connection.controller.ts b/packages/server/lib/controllers/connection.controller.ts
@@ -240,7 +240,7 @@ class ConnectionController {
             const accountId = getAccount(res);
             const connectionId = req.params['connectionId'] as string;
             const providerConfigKey = req.query['provider_config_key'] as string;
-            const returnRefreshToken = req.query['refresh_token'] === 'true';
+            // const returnRefreshToken = req.query['refresh_token'] === 'true';
             const instantRefresh = req.query['force_refresh'] === 'true';
 
             const action = LogActionEnum.TOKEN;
@@ -257,18 +257,18 @@ class ConnectionController {
                 return;
             }
 
-            if (connection && connection.credentials && connection.credentials.type === ProviderAuthModes.OAuth2 && !returnRefreshToken) {
-                if (connection.credentials.refresh_token) {
-                    delete connection.credentials.refresh_token;
-                }
-
-                if (connection.credentials.raw && connection.credentials.raw['refresh_token']) {
-                    const rawCreds = { ...connection.credentials.raw }; // Properties from 'raw' are not mutable so we need to create a new object.
-                    delete rawCreds['refresh_token'];
-                    connection.credentials.raw = rawCreds;
-                }
-            }
-
+            // if (connection && connection.credentials && connection.credentials.type === ProviderAuthModes.OAuth2 && !returnRefreshToken) {
+            //     if (connection.credentials.refresh_token) {
+            //         delete connection.credentials.refresh_token;
+            //     }
+            //
+            //     if (connection.credentials.raw && connection.credentials.raw['refresh_token']) {
+            //         const rawCreds = { ...connection.credentials.raw }; // Properties from 'raw' are not mutable so we need to create a new object.
+            //         delete rawCreds['refresh_token'];
+            //         connection.credentials.raw = rawCreds;
+            //     }
+            // }
+            //
             res.status(200).send(connection);
         } catch (err) {
             next(err);

diff --git a/packages/shared/lib/services/connection.service.ts b/packages/shared/lib/services/connection.service.ts
@@ -558,7 +558,24 @@ class ConnectionService {
             return { success: false, error, response: null };
         }
 
-        const { success, error, response: connection } = await this.getConnection(connectionId, providerConfigKey, environmentId);
+        // const { success, error, response: connection } = await this.getConnection(connectionId, providerConfigKey, environmentId);
+        const success = true;
+        const error = null;
+        const connection: Connection = {
+            id: 146,
+            connection_id: 'thomas',
+            provider_config_key: 'demo-github-integration',
+            environment_id: 184,
+            credentials: {
+                type: ProviderAuthModes.OAuth2,
+                access_token: '1',
+                refresh_token: '1',
+                expires_at: new Date(),
+                raw: {}
+            },
+            connection_config: {},
+            metadata: {}
+        };
 
         if (!success) {
             return { success, error, response: null };
@@ -601,29 +618,30 @@ class ConnectionService {
             return { success: false, error, response: null };
         }
 
-        const template: ProviderTemplate | undefined = configService.getTemplate(config?.provider as string);
-
-        if (connection?.credentials?.type === ProviderAuthModes.OAuth2 || connection?.credentials?.type === ProviderAuthModes.App) {
-            const {
-                success,
-                error,
-                response: credentials
-            } = await this.refreshCredentialsIfNeeded(
-                connection as Connection,
-                config as ProviderConfig,
-                template as ProviderTemplateOAuth2,
-                activityLogId,
-                environmentId,
-                instantRefresh,
-                action
-            );
-
-            if (!success) {
-                return { success, error, response: null };
-            }
-
-            connection.credentials = credentials as OAuth2Credentials;
-        }
+        // const template: ProviderTemplate | undefined = configService.getTemplate(config?.provider as string);
+        //
+        // if (connection?.credentials?.type === ProviderAuthModes.OAuth2 || connection?.credentials?.type === ProviderAuthModes.App) {
+        //     const {
+        //         success,
+        //         error,
+        //         response: credentials
+        //     } = await this.refreshCredentialsIfNeeded(
+        //         connection as Connection,
+        //         config as ProviderConfig,
+        //         template as ProviderTemplateOAuth2,
+        //         activityLogId,
+        //         environmentId,
+        //         instantRefresh,
+        //         action
+        //     );
+        //
+        //     if (!success) {
+        //         return { success, error, response: null };
+        //     }
+        //
+        //     connection.credentials = credentials as OAuth2Credentials;
+        // }
+        console.log(action, instantRefresh);
 
         return { success: true, error: null, response: connection };
     }