fix(connection): import should reset auth errors (#3558)

## Changes Fixes https://linear.app/nango/issue/NAN-2752/import-connection-does-not-clear-auth-error - Import should reset auth errors
NangoHQ · Feb 24, 2025 · c469523 · c469523
1 parent f9edbf0
commit c469523
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 16 deletions.
diff --git a/packages/jobs/lib/execution/sync.integration.test.ts b/packages/jobs/lib/execution/sync.integration.test.ts
@@ -328,10 +328,6 @@ async function seeds(records: UnencryptedRecordData[], trackDeletes: boolean) {
 
     const connection = await seeders.createConnectionSeed({ env, provider: 'github' });
 
-    if (!connection.id) {
-        throw new Error('Failed to create connection');
-    }
-
     const config = await seeders.createConfigSeed(env, 'github', 'github');
     const { syncConfig, sync } = await seeders.createSyncSeeds({
         connectionId: connection.id,

diff --git a/packages/server/lib/controllers/connection.controller.ts b/packages/server/lib/controllers/connection.controller.ts
@@ -6,7 +6,11 @@ import { configService, connectionService, errorManager, NangoError, accountServ
 import { NANGO_ADMIN_UUID } from './account.controller.js';
 import { logContextGetter } from '@nangohq/logs';
 import type { RequestLocals } from '../utils/express.js';
-import { connectionCreated as connectionCreatedHook, connectionCreationStartCapCheck as connectionCreationStartCapCheckHook } from '../hooks/hooks.js';
+import {
+    connectionCreated as connectionCreatedHook,
+    connectionCreationStartCapCheck as connectionCreationStartCapCheckHook,
+    connectionRefreshSuccess
+} from '../hooks/hooks.js';
 import { getOrchestrator } from '../utils/utils.js';
 import { preConnectionDeletion } from '../hooks/connection/on/connection-deleted.js';
 
@@ -393,7 +397,7 @@ class ConnectionController {
                             connection: res.connection,
                             environment,
                             account,
-                            auth_mode: 'API_KEY',
+                            auth_mode: 'BASIC',
                             operation: res.operation,
                             endUser: undefined
                         },
@@ -580,7 +584,7 @@ class ConnectionController {
                 return;
             }
 
-            if (updatedConnection && updatedConnection.connection.id && runHook) {
+            if (updatedConnection && runHook) {
                 void connectionCreatedHook(
                     {
                         connection: updatedConnection.connection,
@@ -596,6 +600,11 @@ class ConnectionController {
                 );
             }
 
+            if (updatedConnection && updatedConnection.operation === 'override') {
+                // If we updated the connection we assume the connection is now correct
+                await connectionRefreshSuccess({ connection: updatedConnection.connection, environment, config: integration });
+            }
+
             res.status(201).send({
                 ...req.body,
                 connection_id: connectionId

diff --git a/packages/server/lib/hooks/hooks.ts b/packages/server/lib/hooks/hooks.ts
@@ -135,14 +135,10 @@ export const connectionRefreshSuccess = async ({
     environment,
     config
 }: {
-    connection: DBConnectionDecrypted;
+    connection: Pick<DBConnectionDecrypted, 'id' | 'connection_id' | 'provider_config_key' | 'environment_id'>;
     environment: DBEnvironment;
     config: IntegrationConfig;
 }): Promise<void> => {
-    if (!connection.id) {
-        return;
-    }
-
     await errorNotificationService.auth.clear({
         connection_id: connection.id
     });

diff --git a/packages/shared/lib/clients/orchestrator.ts b/packages/shared/lib/clients/orchestrator.ts
@@ -124,10 +124,6 @@ export class Orchestrator {
         });
         const startTime = Date.now();
         try {
-            if (!connection.id) {
-                throw new NangoError('invalid_input', { connection });
-            }
-
             let parsedInput: JsonValue = null;
             try {
                 parsedInput = input ? JSON.parse(JSON.stringify(input)) : null;