Add persist API #1575
Merged
Add persist API #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
force-pushed
the
tbonnin/persist-1
branch
from
0e89a47
to
e9920ba
Compare
TBonnin
commented
Jan 30, 2024
| steps[step - 1]?.(); | ||
| }; | ||
| } | ||
| } |
There was a problem hiding this comment.
ideally I would like to have a real in-memory database that can be used in tests. But knex in-memory solution is to use sqlite which doesn't support our schema.
So for now I am just mocking the db queries
TBonnin
force-pushed
the
tbonnin/persist-1
branch
from
e9920ba
to
7cfb5fe
Compare
TBonnin
commented
Jan 30, 2024
| } else { | ||
| next(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
do we want some sort of authorization mechanism to make sure requests are legit and actually made from a runner?
There was a problem hiding this comment.
If the persist service is a private service then I don't think that is necessary yet.
TBonnin
force-pushed
the
tbonnin/persist-1
branch
3 times, most recently
from
1549099
to
bbf9399
Compare
TBonnin
commented
Jan 30, 2024
packages/persist/lib/server.ts
Outdated
| }), | ||
| body: z.object({ | ||
| activityLogId: z.number(), | ||
| level: z.enum(['info', 'debug', 'error', 'warn', 'http', 'verbose', 'silly']), |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
TBonnin
force-pushed
the
tbonnin/persist-1
branch
14 times, most recently
from
2da6a86
to
4534a44
Compare
khaliqgant
reviewed
Jan 31, 2024
.github/workflows/deploy.yaml
Outdated
| docker buildx imagetools create nangohq/nango-persist:${{ github.sha }} --tag nangohq/nango-persist:${{ inputs.stage }} | ||
| - name: Deploy persist | ||
| run: | | ||
| SERVICE_ID=${{ fromJson('{ production: "srv-XXXXXXXXXXXXX", staging: "srv-cmsfiqqcn0vc73bhcod0" }')[inputs.stage] }} |
There was a problem hiding this comment.
We have this prod value now right?
There was a problem hiding this comment.
yep. let me update it
khaliqgant
reviewed
Jan 31, 2024
packages/persist/lib/server.ts
Outdated
| export const server = express(); | ||
| server.use(express.json()); | ||
|
|
||
| // logging middleware |
There was a problem hiding this comment.
can the non helpful comments be removed?
khaliqgant
reviewed
Jan 31, 2024
packages/persist/lib/server.ts
Outdated
| console.log(`[Persist] ${req.method} ${req.path} ${res.statusCode}`); | ||
| }); | ||
|
|
||
| // routes |
khaliqgant
reviewed
Jan 31, 2024
packages/persist/lib/server.ts
Outdated
| ); | ||
| server.put('/environment/:environmentId/connection/:connectionId/sync/:syncId/job/:syncJobId/records', validateRecordsRequest, persistController.updateRecords); | ||
|
|
||
| // error handling middleware |
khaliqgant
approved these changes
Jan 31, 2024
The goal is to remove the database dependency for the runner. Writing customers data (batchSave/.../activityLogs/lastSyncDate) will go through this API
TBonnin
force-pushed
the
tbonnin/persist-1
branch
from
4534a44
to
e741e5f
Compare
khaliqgant
reviewed
Feb 2, 2024
| type LogLevel = 'info' | 'debug' | 'error' | 'warn' | 'http' | 'verbose' | 'silly'; | ||
| import axios from 'axios'; | ||
| import { getPersistAPIUrl } from '../utils/utils.js'; | ||
| import type { LogLevel } from '../models/Activity.js'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit implementing the persist API.
The goal is to remove the database dependency for the runner. Writing customers data (batchSave/.../activityLogs/lastSyncDate) will go through this API
All of it behind a feature flag
Next PR: take care of removing db dependency for proxy.
Issue ticket number and link
https://linear.app/nango/issue/NAN-270/persist-api
Checklist before requesting a review (skip if just adding/editing APIs & templates)