Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration-templates): improve google-drive templates #2727

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

hassan254-prog
Copy link
Contributor

Describe your changes

  • Improve google-drive integration templates
  • Follow up of 2665

Issue ticket number and link

EXT-145

Copy link

linear bot commented Sep 13, 2024

Copy link
Collaborator

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm wondering what happen in the UI if you have fetch-pdf enabled

@hassan254-prog
Copy link
Contributor Author

@bodinsamuel
image


export const mimeTypeMapping: Record<string, MimeTypeMapping> = {
// Documents
'application/vnd.google-apps.document': { mimeType: 'application/vnd.openxmlformats-officedocument.wordprocessingml.document', responseType: 'text' },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this mapping and the one below come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • application/vnd.google-apps.document: This is a MIME type used by Google Drive to represent Google Docs documents.
  • mimeType: application/vnd.openxmlformats-officedocument.wordprocessingml.document specifies the desired MIME type for the converted file, which is the standard MIME type for Microsoft Word documents in the Office Open XML format.

@khaliqgant khaliqgant enabled auto-merge (squash) September 17, 2024 10:39
@khaliqgant khaliqgant merged commit 7bd22eb into master Sep 17, 2024
22 checks passed
@khaliqgant khaliqgant deleted the wari/ext-145-refractor-google-drive-integrations branch September 17, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants