Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): Invalidate cache on deleting integrations and adding connection from integration page #3068

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

nalanj
Copy link
Contributor

@nalanj nalanj commented Nov 26, 2024

I noticed a couple of places where the connection list cache wasn't being correctly invalidated:

  1. When creating a new connection from the integrations page (like right after creating a new integration).
  2. When deleting an integration.

How I Tested This

  1. Go to Connections so the cache is warmed up
  2. Create a new Unauthenticated Integration
  3. Create a new connection for the new Unauthenticated integration
  4. Return to Connections. The new connection should be in the list.
  5. Go back to the new integration, go to the settings tab, and delete it.
  6. Go back to connections. The new connection should now be gone.

@nalanj nalanj self-assigned this Nov 26, 2024
@nalanj nalanj marked this pull request as ready for review November 26, 2024 20:27
@nalanj nalanj requested a review from a team November 26, 2024 20:27
Copy link
Collaborator

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 💨

packages/webapp/src/hooks/useConnections.tsx Outdated Show resolved Hide resolved
Copy link

gitguardian bot commented Nov 27, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8205899 Triggered Generic Password dd2465b packages/database/lib/getDbConfig.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@nalanj nalanj merged commit 7c01381 into master Nov 27, 2024
20 checks passed
@nalanj nalanj deleted the alan/delete-integration-connections-cached branch November 27, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants